Repository navigation
Share AudioFrame plane count with AudioPlane - #2504
Merged
Merged
Conversation
Factor the plane-count formula into AudioFrame._nb_planes() so AudioFrame.planes and AudioPlane.__cinit__ cannot disagree, and add a regression test for layouts with more than 8 channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2502.
AudioFrame._nb_planes()soAudioFrame.planesandAudioPlane.__cinit__share one definition. The original bug came from these two copies disagreeing.test_manual_fltp_22_2_constructor: a 24-channel22.2layout, covering the more-than-8-channel case whereextended_datais a separate heap array.