Repository navigation
Mark Cython classes @final and dunder parameters positional-only in stubs - #2465
Merged
Merged
Conversation
… stubs Fixes the stubtest errors for 34 classes that cannot be subclassed at runtime and 19 dunder methods whose parameters are positional-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 53 stubtest errors:
X cannot be subclassed at runtime, but isn't marked with @final in the stub: added@finalto every Cython class stubtest flagged, across 26 stubs (frames, planes, streams, formats, layouts,Codec,Packet,AVRational, filter classes, and others).stub parameter "x" should be positional-only: added/toAVRational's comparison and arithmetic dunders (every overload included),Dictionary.__getitem__/__setitem__/__delitem__,IndexEntries.__getitem__, andFilterPad.__eq__.Stubtest reports none of these afterwards and no new errors.
mypy av testsis unchanged, and the test suite passes.The
@disjoint_baseerrors (also 34) are left alone; that decorator is new intyping_extensionsand optional.