Repository navigation
Fix stub errors in hwaccel, error, and ThreadType - #2462
Merged
Merged
Conversation
- Remove unused `HWAccel.codec` field, which was never assigned - Add `ErrorType` and `__all__` to `av/error.pyi` - Stub `thread_type` as a property instead of giving `ThreadType` fake `__get__`/`__set__` methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes these stubtest errors:
HWAccel.codec: nothing ever assigned this field, so it was alwaysNone. Removed it fromhwaccel.pxdrather than stubbing it.ErrorType: added the enum, itstag/strerrorproperties, and__all__toerror.pyi.ThreadType: the stub gaveThreadTypefake__get__/__set__methods so thatctx.thread_type = "AUTO"would type-check.thread_typeonCodecContextandVideoStreamis now a property whose setter acceptsint | str | ThreadType, matching the runtime setter.VideoStreamforwardsthread_typeto its codec context, so stubtest now reportsVideoStream.thread_type is not present at runtime. Keeping it as a plain annotation would breakstream.thread_type = "AUTO"under mypy.