Support Embedded targets without a concurrency runtime#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows CoreModel to compile for Embedded Swift targets whose stdlib ships no
_Concurrencyslice (e.g. bare-metal ARM like the Nintendo DS's ARM946E-S,armv5te-none-none-eabi).ModelStorage(async requirements) and theInMemoryModelStorageactor are now gated oncanImport(_Concurrency)instead of assuming a concurrency runtime. No change on any platform that has one, including Embedded wasm.InMemoryStorage— the synchronous, typed-throws backing store introduced with the in-memory store — is nowpublic, so concurrency-less Embedded consumers have a usable storage API (it already elides its lock under Embedded).Testing
swift build+swift teston macOS: 22 tests pass.SWIFT_EMBEDDED=1 swift build --swift-sdk swift-6.3.3-RELEASE_wasm-embedded --target CoreModel: builds as before.swiftc -target armv5te-none-none-eabi -enable-experimental-feature Embeddedover all CoreModel sources (with FoundationEmbedded prebuilt): compiles clean — previously failed on the async protocol and actor.