Add DisclosureGroup#64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisclosureGroup— a label that expands to reveal its content. Supports a plain title or a view label, and either self-managed or bound expansion.Shape
Emitted as one node whose children are
[label..., content...], with alabelCountprop marking where the header ends and the body begins. Expansion has two modes:isExpanded:) — the header tap round-trips through a callback so Swift stays the source of truth, exactly like aToggleThe interpreter draws a tappable header (label + a chevron that flips up/down) and shows the content only while expanded.
Verification
swift test— 3 new tests, 115 passing: the label/content boundary vialabelCount, that an unbound group emits no expansion state (the interpreter owns it), the bound round-trip (onToggleflipsisExpanded), and aLabelview as the header.Labelheader (star + "Notifications") and stays collapsed with a down-chevronScope
DisclosureGroupStylefor custom presentation isn't modeled; the built-in header (label + chevron, content indented) is the only layout.