Add Link#61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link("title", destination:)andLink(destination:) { label }— opens a URL outside the app.No bridge involvement
The whole hop stays out of Swift: the interpreter hands the address to Compose's
LocalUriHandler, so the platform picks which app answers it. No callback registered, no bridge entry. The label takes the accent colour (via the existingLocalInheritedColorfold) so it reads as a link, unless something upstream already tinted it — and the open is wrapped inrunCatchingso a malformed or unhandled address can't crash the app.Verification
swift test— 2 new tests, 107 passing: the destination and label emit, noonTapcallback is registered (the interpreter opens it itself), and a customHStacklabel survives.act=android.intent.action.VIEW dat=https://swift.org, anddumpsysconfirmed Chrome became the resumed activity. The URL genuinely opened in the browser, not just a logged intent. The custom-label link (icon + text) and the in-sentence link both render correctly.Scope
http(s)and other app-resolvable schemes go through the system handler.Linkdoesn't style beyond the accent colour (no underline — ComposeTexthas it, but SwiftUI's ownLinkdoesn't underline either), and there's noOpenURLActionenvironment override.