Add constructors to form control bindings#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeekBar,EditText, andSpinnerdeclared no constructors, so none of them could be instantiated from Swift. Their class hierarchies are already correct — this only adds the four standard view constructors to each, along with theAndroidContent/AndroidUtil/AndroidViewimports they require.Same shape as the
ProgressBarfix in #45, and needed for the same reason: rendering SwiftUI'sSlider,TextField, andPickeronto their native counterparts.Verification
swift build --swift-sdk aarch64-unknown-linux-android28completes on this branch.Consumed downstream in AndroidSwiftUI, which renders
Slider,TextField, andPicker.