Declare Apple platform requirements and align swift-android-native source#43
Open
colemancda wants to merge 1 commit into
Open
Declare Apple platform requirements and align swift-android-native source#43colemancda wants to merge 1 commit into
colemancda wants to merge 1 commit into
Conversation
…ip-android-bridge
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two manifest fixes found while building a downstream app (BluetoothExplorer) that depends on this
package transitively.
Declare Apple platform requirements
The package declared only
.macOS(.v15). SwiftPM defaults unspecified platforms to iOS 12, whileSocket/Bluetoothand friends require iOS 13 — so any Apple-platform resolve of a graphcontaining this package failed:
That was 4 of 15 such errors in the downstream app; the rest came from
AndroidBluetooth(PureSwift/AndroidBluetooth#…) and swift-java.
Now declares
.iOS(.v13), .watchOS(.v6), .tvOS(.v13)to match the dependencies. This package onlyever builds for Android, but SwiftPM validates platform requirements across the whole graph
regardless of
.when(platforms:)conditions, so the declaration has to be there.Align the swift-android-native source
This package pointed at
swift-android-sdk/swift-android-native@main, whileMillerTechnologyPeru/skip-android-bridgepoints atMillerTechnologyPeru/swift-android-native@feature/pureswift. SwiftPM resolves by packageidentity, so a graph containing both is unresolvable:
Now points at the same fork/branch the bridge uses.
Note: this depends on MillerTechnologyPeru/swift-android-native#… (merging current upstream
mainintofeature/pureswift), because the fork was 87 commits behind and did not yet exportAndroidManifest,AndroidFileManager,AndroidInputorAndroidHardware, which this packagerequires. Merge that first.