Fix/getcloser security config #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ PR ํ์
๐จ ์์ ๋ด์ฉ
getcloser์๋น์ค์ ๋ณด์ ์ค์ ์ ๊ฐํํ๊ณ ํ๊ฒฝ ๋ณ์ ๊ด๋ฆฌ๋ฅผ ๊ฐ์ ํ์ต๋๋ค.getcloser/backend/app/core/config.py)SECRET_KEY์ ๊ธฐ๋ณธ๊ฐ์ ์ ๊ฑฐํ๊ณ ,ENVIRONMENT๊ฐprod๋๋production์ผ ๋ ํ๊ฒฝ ๋ณ์๊ฐ ์ค์ ๋์ง ์์๊ฑฐ๋ ๊ธฐ๋ณธ๊ฐ์ ๊ทธ๋๋ก ์ฌ์ฉ ์ค์ด๋ฉด ์๋ฒ ์์์ ์ฐจ๋จํ๋๋กPydanticvalidator๋ฅผ ์ถ๊ฐํ์ต๋๋ค.getcloser/backend/.env.example).env.exampleํ์ผ์ ์์ฑํ๊ณ ,openssl์ ์ด์ฉํ ์ํฌ๋ฆฟ ํค ์์ฑ ๋ฐฉ๋ฒ์ ์ฃผ์์ผ๋ก ์๋ดํ์ต๋๋ค..github/workflows/deploy-getcloser.yml)SECRET_KEY์ENVIRONMENT=prod๋ณ์๊ฐ.envํ์ผ์ ์ฃผ์ ๋๋๋ก ์คํ ์ ์์ ํ์ต๋๋ค.์ฎ์ธ ์ด์
๐ธ ์คํฌ๋ฆฐ์ท
(ํด๋น ์์ - ๋ฐฑ์๋ ์ค์ ๋ฐ CI ์์ )
๐งโ๐ป ํ ์คํธ ๊ฒฐ๊ณผ
ENVIRONMENT=dev)์์ ์๋ฒ ์ ์ ๊ตฌ๋ ํ์ธ.SECRET_KEYํ๊ฒฝ ๋ณ์๋ฅผ ์ ๊ฑฐํ๊ณENVIRONMENT=prod๋ก ์ค์ ์ ์๋ฒ ๊ตฌ๋ ์คํจ(Validation Error) ํ์ธ.๐ ์ฒดํฌ๋ฆฌ์คํธ
.env.example)