Skip to content

[codex] remove legacy frontends #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rikohomeless wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[codex] remove legacy frontends #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ docker-git --help
```

Структура проекта:
APP - CLI + React (Frontend)
LIB - Весь бекенд (Основная бизнес логика)
API - Просто апи сервер поднятный над LIB
APP - CLI + browser frontend (`docker-git browser`)
LIB - основная бизнес-логика
API - только API server над LIB

APP работает только с API, и не имеет доступа к LIB
API работает только с LIB
APP работает с API; единственная пользовательская frontend-поверхность запускается через `docker-git browser`.
API работает только с LIB и не сервит встроенный HTML frontend.

## Runtime contract: host-Docker-backed

Expand Down
29 changes: 0 additions & 29 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions packages/api/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@ Diagnostic classification + remediation messages live in
`packages/app/src/docker-git/controller-docker-diagnostics.ts` and are
covered by `packages/app/tests/docker-git/controller-docker-diagnostics.test.ts`.

## UI wrapper

After API startup open:

- `http://localhost:3334/`

This page is a built-in UI shell for manual API checks without CLI.

## Run (local)

```bash
Expand Down
14 changes: 2 additions & 12 deletions packages/api/src/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import {
UpProjectRequestSchema
} from "./api/schema.js"
import type { UpProjectRequestInput } from "./api/schema.js"
import { uiHtml, uiScript, uiStyles } from "./ui.js"
import { defaultProjectsRoot } from "@effect-template/lib/usecases/menu-helpers"
import { resolveWorkspaceRoot } from "@effect-template/lib/shell/workspace-root"
import {
Expand Down Expand Up @@ -762,16 +761,7 @@ const projectProxyResponse = Effect.gen(function*(_) {
})

export const makeRouter = () => {
const withUi = HttpRouter.empty.pipe(
HttpRouter.get("/",
Effect.gen(function*(_) {
const request = yield* _(HttpServerRequest.HttpServerRequest)
console.log("GET / request:", request.url, "headers:", request.headers)
return yield* _(textResponse(uiHtml, "text/html; charset=utf-8", 200))
}).pipe(Effect.catchAll(errorResponse))
),
HttpRouter.get("/ui/styles.css", textResponse(uiStyles, "text/css; charset=utf-8", 200)),
HttpRouter.get("/ui/app.js", textResponse(uiScript, "application/javascript; charset=utf-8", 200)),
const withCoreRoutes = HttpRouter.empty.pipe(
HttpRouter.get(
"/health",
Effect.gen(function*(_) {
Expand Down Expand Up @@ -805,7 +795,7 @@ export const makeRouter = () => {
)
)

const withAuth = withUi.pipe(
const withAuth = withCoreRoutes.pipe(
HttpRouter.get(
"/auth/github/status",
Effect.gen(function*(_) {
Expand Down
4 changes: 2 additions & 2 deletions packages/api/src/services/auth-terminal-sessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ const resolveCommandLabel = (request: AuthTerminalSessionRequest): string => {
const label = request.label?.trim()
const suffix = label === undefined || label.length === 0 ? "" : ` [${label}]`
return request.flow === "ClaudeOauth"
? `docker-git menu auth claude oauth${suffix}`
: `docker-git menu auth gemini oauth${suffix}`
? `Claude Code OAuth${suffix}`
: `Gemini CLI OAuth${suffix}`
Comment on lines +73 to +74
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major | 🏗️ Heavy lift

Рассмотрите переименование поля или добавление отдельного displayLabel.

Поскольку поле sshCommand больше не содержит исполняемую SSH/CLI команду, рассмотрите одно из решений:

  1. Переименовать sshCommand → displayLabel или sessionLabel
  2. Добавить отдельное поле displayLabel и сохранить sshCommand для обратной совместимости
  3. Обновить документацию контракта, явно указав, что sshCommand — это человекочитаемая метка, а не команда

}

const resolveRunnerArgs = (flow: AuthTerminalFlow, label: string | null | undefined): ReadonlyArray<string> => {
Expand Down
Loading
Loading