Unify snapshot compilation under complete-cost selection - #698
Closed
zzylol wants to merge 2 commits into
Closed
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Snapshot startup had two selection policies: unquoted v1 compatibility compilation and complete-cost selection. Deployment should use one evidence-required path.
What / how
compile_workload_artifact, including logical selection and revision metadata; removeinspect_physical_dag.Before this PR
An unquoted v1 snapshot could start a backend without complete-cost selection. Mixed candidate masks could discard DDSketch bindings; missing entropy evidence could also prevent an otherwise valid L2 summary plan.
After this PR
Export candidates → measure and attach quotes → compile/select → deploy. An unquoted snapshot fails deployment explicitly. Schema version 2 is a format marker, not a second compiler mode.
Verification
Compatibility / limitations
This intentionally rejects schema 1 and unquoted snapshot deployment. Demo runs require
ASAPQUERY_PLANNING_SNAPSHOTwith valid quotes. Low-level physical binding and distributed publication APIs are outside this snapshot cleanup. Validation used Rust 1.98.0 and the CI-pinned sketchlib checkout. No new performance measurements or visual evidence apply.