Select dashboard tumbling pane sizes and enforce window correctness - #527
Merged
Merged
Conversation
This was referenced Sep 8, 2026
…g-review # Conflicts: # control_plane/src/physical/compiler.rs # control_plane/src/physical/post_asap/tests.rs # control_plane/src/query_plan.rs # data_plane/src/query_engines/asap_query_engine/summary_exec.rs
…:ProjectASAP/ASAPQuery-backend into codex/pr527-accounting-review
…g-review # Conflicts: # control_plane/src/physical/workload_cost.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #526. Planning and execution guards land together because accepting smaller panes without validating the read interval can return incomplete warm results.
Before this PR
Backend-local compilation accepted only lookback-sized Tumbling states, discarded concrete IDs during framework costing, and replaced the original lifecycle time scope with Unknown. Raw pane membership also used
[start,end)although PromQL requires(start,end]. A production regression returned 10230 instead of 230 after wrongly including a left-boundary sample.After this PR
abb2f20e27091ac0c60715dc42b9b59c75b3447c.Verification
cargo test -p control_plane --lib: 660 passed.cargo test -p data_plane --lib -- --test-threads=1: 982 passed.cargo test -p data_plane --test asapquery_compatibility_process_e2e -- --test-threads=1: 3 passed.Sparse panes without explicit completion evidence conservatively fall back. Logical window expiration does not imply immediate physical reclamation. Candidate costs remain provider supplied; this PR does not invent a measured cost formula. Collector deployments retain lookback-sized panes. This is correctness/conformance coverage, not the real o11ybench benefit report.
Developer contract and reproduction:
docs/developer_docs/planning/repeated-dashboard-panes.md.