Select complete bound workloads with strict cost and capability evidence - #522
Merged
Merged
Conversation
zzylol
changed the base branch from
test/successful-generation-cutover
to
main
September 8, 2026 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The migration stack reported joint shared-producer lifecycle components, but did not compare complete bound workloads before deployment. Missing source, state, transport and query-operator costs could not be distinguished from a fully priced decision. Exact fallback compilation unnecessarily required unused state/window evidence.
After
Validation
Six focused cost tests cover selection reversal under expensive retention, one producer for two consumers, missing/duplicate/stale/mismatched/infeasible/negative evidence, strict v2 replay, and no unused-state evidence for exact fallback.
Production-process acceptance exercises quoted v2 shared exact dashboard startup and live distributed manifest/quote/publish/query flow, including actual Collector Rust updates and concurrent generation cutover. Synthetic fixture prices test selection; they are not production calibration.
Local combined-stack results: 654 control-plane library tests, 28 binary tests, one control-plane integration test, 977 data-plane library tests, and three production-process tests passed.
cargo fmt -p control_plane -p data_plane -- --checkandgit diff --checkpassed. Existing compiler warnings were not expanded into unrelated cleanup.Scope and dependency
Stacked on #521 (
test/successful-generation-cutover), following #513–#520 and merged Planner #356/#357. Do not merge independently or automatically.This implements provider-priced complete selection for the supported runtime profile, not exhaustive search across all Planner algorithms/lifecycles. Additional Planner-authorized bindable forests can use the same comparison boundary. The deployment must supply and refresh real cost/capability evidence; no production telemetry is invented. The generic Planner physical-formula provider is not reimplemented using guessed source statistics.
No independent reviewer was used; this PR has implementation tests and self-review.
Planner #357 compatibility update
Pins all Planner crates and the emitted
PLANNER_REVISIONto merged commitc3410d14865497758d212e4265ad25c782187de1. The existing provider-priced workload comparison remains compatible; this update does not enable the separate offline empirical execution prototype. Regenerate manifests and quotes for the new Planner revision.Includes the reviewed exact-fallback fix: enumerate and deduplicate every named input source, and reject incomplete or unresolved source coverage. On this branch, 657 control-plane library tests, 29 binary tests and one integration test pass with the merged Planner revision.