fix(precompute): restore weighted sketch updates - #482
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
PR #481 treated every raw Prometheus sample sent to bare CMS and CountSketch as one event. That changes metric-value aggregation into scrape counting: samples with values
2,3, and5estimate3instead of10.ASAPQuery #665 did not make unit weighting unconditional. It introduced an explicit
count_eventschoice between1.0and the datapoint value. The current backend physical plan has no equivalent typed count-vs-value contract, so inferring count mode from the sketch kind is incorrect.After
2 + 3 + 5estimate10for both sketches.Value/Countmodes for heap sketches.Verification
cargo fmt -p data_plane -- --checkcargo test -p data_plane bare_cms_adds_sample_valuescargo test -p data_plane bare_count_sketch_adds_sample_valuesBoth targeted tests pass. Existing compiler warnings are unchanged.