feat: represent exact maintenance binary timing explicitly - #402
Merged
Conversation
zzylol
changed the title
zzylol
marked this pull request as ready for review
September 11, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual selected plan for
quantile(0.9, sum_over_time(m[1m]) + sum_over_time(n[1m]))could not export: its binary value was always read-time even when consumed by maintained state.Add explicit ExecutionTiming to the existing BinaryOp and executable Binary payload. Maintained exact arithmetic retimes cloned Binary/Finalize value boundaries, preserving read-time consumers, schemas, operands and guarantees. Shared validation checks matching input timing and scalar schemas; CSE distinguishes execution timing. Missing wire timing defaults to ReadTime and ReadTime serialization omits the field, preserving existing wire identity.
Before: the real selected two-source candidate failed ReadoutUnderMaintenance. After: it exports an explicit maintenance binary and exact-finalize boundaries. This is a typed planning contract; backend consumers must explicitly implement MaintenanceTime arithmetic and must not reinterpret old ReadTime payloads.
Validation: 18 PromQL integration tests, including actual two-source selection/export and legacy wire roundtrip; 404 mapping and 196 shared-type unit tests passed before the final stricter maintenance schema check. Final integration rerun verifies that check. Runtime performance is not claimed.