Skip to content

Read the settled brand variable names - #794

Merged
ilicfilip merged 5 commits into
developfrom
filip/brand-variable-names
Oct 29, 2026
Merged

ilicfilip merged 5 commits into
developfrom
filip/brand-variable-names

Conversation

@ilicfilip

Copy link
Copy Markdown
Collaborator

Progress Planner side of the brand variable names the designer confirmed. Goes together with the pp-hosts, AI Connector and your-branding PRs below; merge them around the same time.

What changes

  • Radius: papers use --prpl-radius-paper (8px), buttons --prpl-radius-button (6px). --prpl-border-radius is gone; -big stays internal.
  • Selection controls: --prpl-color-selection-controls is the unchecked grey (#9ca3af), -active the checked color (default #3bb3a6). -inactive and the local --prpl-input-green/-gray are gone.
  • Graph colors: the middle score band (gauge, bar chart, dashboard widget) and "published" use graph color 2; "deleted" uses graph color 4.
  • Own names: --prpl-color-divider (#d1d5db), visited links, --prpl-color-text-score / -small, --prpl-color-border-point (0.8px, none by default), streak and content badge gauge colors, --prpl-color-publish / -flying-start.
  • Computed: topic, top-task, publish and flying-start backgrounds are 10% of their color on paper; the primary hover is the primary color 10% darker.
  • Alerts: 1px border on every alert (--prpl-color-border-alert-*).
  • Secondary button: the outline button (border, text, 6% hover tint).
  • Deleted: the nine names no plugin read (button shadow/border, settings page icons and backgrounds, settings border).

Testing

  • phpstan, stylelint and eslint pass.
  • Checked in the browser on a local site with the new Zonnet CSS: content activity and gauge colors, badge tints, divider, alert borders, button radius, secondary outline. Console clean.
  • pp-hosts loads Progress Planner from the pp-hosts branch, so this needs to reach that branch before the pp-hosts PR works.

🤖 Generated with Claude Code

ilicfilip and others added 3 commits October 28, 2026 09:50
Papers and buttons use --prpl-radius-paper / --prpl-radius-button.
Checkboxes and toggles use --prpl-color-selection-controls (unchecked) and
-active (checked). The middle score band and "published" use graph color 2,
"deleted" graph color 4. Dividers, visited links, score text, the points
badge border and the streak and content badge gauges get their own names.
Alerts get a 1px border. Topic, top-task and gauge backgrounds are 10% of
their color, the primary hover 10% darker. The secondary button becomes
the outline button. Nine names nothing read are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The layer covers the button's own background, which hid an inset outline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 33.90% 📉
Base Coverage 33.90%
Difference 📈 0.00%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
10 0 10

⚠️ Warnings (10)

📁 classes/suggested-tasks/data-collector/class-unpublished-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
103 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/providers/class-content-review.php (4 warnings)
📍 Line 🔖 Check 💬 Message
232 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
377 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
381 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
388 WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://docs.wpvip.com/databases/optimize-queries/using-post__not_in/ for more information.
📁 classes/suggested-tasks/data-collector/class-terms-without-description.php (1 warning)
📍 Line 🔖 Check 💬 Message
108 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 106.
📁 classes/suggested-tasks/data-collector/class-terms-without-posts.php (1 warning)
📍 Line 🔖 Check 💬 Message
120 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_results()\n$query assigned unsafely at line 118.
📁 classes/suggested-tasks/data-collector/class-yoast-orphaned-content.php (1 warning)
📍 Line 🔖 Check 💬 Message
111 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $query used in $wpdb->get_row()\n$query assigned unsafely at line 98.
📁 classes/activities/class-query.php (2 warnings)
📍 Line 🔖 Check 💬 Message
71 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $table_name used in $wpdb->query()\n$table_name assigned unsafely at line 58.
163 PluginCheck.Security.DirectDB.UnescapedDBParameter Unescaped parameter $where_args used in $wpdb->get_results()\n$where_args assigned unsafely at line 153.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

ilicfilip and others added 2 commits October 28, 2026 13:50
--prpl-color-text-placeholder and --prpl-color-text-dropdown were defined
but never read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When YOUR_BRANDING_DIR points at a your-branding checkout, the hook checks
every --prpl-* name the plugin reads or defines against its tokens.json.
Without it the check is skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ilicfilip
ilicfilip marked this pull request as ready for review October 29, 2026 06:55
@ilicfilip
ilicfilip merged commit d41e7c4 into develop Oct 29, 2026
22 checks passed
@ilicfilip
ilicfilip deleted the filip/brand-variable-names branch October 29, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant