Repository navigation
Fix CI: update mediawiki-codesniffer to 52 - #141
Merged
Merged
Conversation
Composer refuses to install mediawiki-codesniffer 46 because the PHP_CodeSniffer version it pins, 3.11.3, has a security advisory, so the code style, PHPStan and Psalm CI jobs failed during composer install. Version 52 requires PHP_CodeSniffer 3.13.6, which has the fix. The code already passes its rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer refuses to install package versions with known security advisories, which broke this repository's code style, PHPStan and Psalm jobs: mediawiki-codesniffer 46 pins PHP_CodeSniffer 3.11.3, which is affected by PKSA-rdkp-vv9z-mjkg. This updates mediawiki-codesniffer to 52, whose PHP_CodeSniffer 3.13.6 has the fix. The code already passes the new rules.
Human input
Goal and shape: goal from @alistair3149 ("Fix the WikibaseRDF fail CI"); shape Claude's.
Outcome: not reviewed by a human yet. Left for you: nothing beyond a skim; the change is one line.
Claude's calls
^52.0.0, as in our other extensions. Installing the dev tools then needs PHP 8.3, which every CI job that installs them already uses; the extension itself still needs PHP 8.1.Generic.Formatting.NoSpaceAfterCastrule in phpcs.xml, which still runs but warns.The change
composer.json: mediawiki-codesniffer^46.0.0→^52.0.0.#140 keeps showing these jobs red until this is merged and master is merged into it.
Verification evidence
squizlabs/php_codesniffer[3.11.3] … affected by security advisories ("PKSA-rdkp-vv9z-mjkg"). Logs of the earlier runs have expired.composer:2(PHP 8.5.12, Composer 2.10.3, advisory blocking on):composer installsucceeds, andvendor/bin/phpcs -p -spasses on all 71 files with PHP_CodeSniffer 3.13.6.