Skip to content

Fix CI: update mediawiki-codesniffer to 52 - #141

Merged
alistair3149 merged 1 commit into
masterfrom
alistair3149/codesniffer-52
Nov 12, 2026
Merged

alistair3149 merged 1 commit into
masterfrom
alistair3149/codesniffer-52

Conversation

@alistair3149

@alistair3149 alistair3149 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Composer refuses to install package versions with known security advisories, which broke this repository's code style, PHPStan and Psalm jobs: mediawiki-codesniffer 46 pins PHP_CodeSniffer 3.11.3, which is affected by PKSA-rdkp-vv9z-mjkg. This updates mediawiki-codesniffer to 52, whose PHP_CodeSniffer 3.13.6 has the fix. The code already passes the new rules.

Human input

Goal and shape: goal from @alistair3149 ("Fix the WikibaseRDF fail CI"); shape Claude's.

Outcome: not reviewed by a human yet. Left for you: nothing beyond a skim; the change is one line.

Claude's calls

  • Not discussed with @alistair3149: ^52.0.0, as in our other extensions. Installing the dev tools then needs PHP 8.3, which every CI job that installs them already uses; the extension itself still needs PHP 8.1.
  • Considered by Claude, omitted: replacing the deprecated Generic.Formatting.NoSpaceAfterCast rule in phpcs.xml, which still runs but warns.

The change

  • composer.json: mediawiki-codesniffer ^46.0.0 → ^52.0.0.

#140 keeps showing these jobs red until this is merged and master is merged into it.

Verification evidence
  • Master CI has failed since 2026-08-06; run 38246519121 (2026-10-12) and Move to ESLint 9 and flat config #140 fail at "Composer install" in code style, PHPStan and Psalm: squizlabs/php_codesniffer[3.11.3] … affected by security advisories ("PKSA-rdkp-vv9z-mjkg"). Logs of the earlier runs have expired.
  • PKSA-rdkp-vv9z-mjkg affects PHP_CodeSniffer below 3.13.6; mediawiki-codesniffer 52.0.x requires 3.13.6.
  • Locally, in Docker composer:2 (PHP 8.5.12, Composer 2.10.3, advisory blocking on): composer install succeeds, and vendor/bin/phpcs -p -s passes on all 71 files with PHP_CodeSniffer 3.13.6.
  • CI on this PR (runs 43314706698 and 43314716023): code style, PHPStan, Psalm, PHPUnit (REL1_43 on PHP 8.1, 8.2 and 8.3; master on PHP 8.4) and linting all pass.

AI-authored — Claude Code, Opus 5.5, on a Professional Wiki account

Composer refuses to install mediawiki-codesniffer 46 because the
PHP_CodeSniffer version it pins, 3.11.3, has a security advisory, so the
code style, PHPStan and Psalm CI jobs failed during composer install.
Version 52 requires PHP_CodeSniffer 3.13.6, which has the fix. The code
already passes its rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alistair3149
alistair3149 marked this pull request as ready for review November 12, 2026 22:00
@alistair3149
alistair3149 merged commit a968106 into master Nov 12, 2026
16 checks passed
@alistair3149
alistair3149 deleted the alistair3149/codesniffer-52 branch November 12, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant