Repository navigation
Fix CI: update mediawiki-codesniffer and drop MediaWiki 1.39 to 1.42 jobs - #195
Merged
Merged
Conversation
Composer now refuses to install package versions with known security advisories. MediaWiki 1.39 to 1.42 pin dependencies that have one, such as PHPUnit 9.6.16 and Guzzle, so these jobs fail while installing MediaWiki, before any test runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Composer refuses to install mediawiki-codesniffer 40 because the PHP_CodeSniffer version it pins has a security advisory, so the code style and static analysis CI jobs failed during composer install. Version 52 requires PHP_CodeSniffer 3.13.6, which has the fix. Apply the new rules with phpcbf: static arrow functions, explicit nullable types and whitespace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
alistair3149
marked this pull request as ready for review
November 12, 2026 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer now refuses to install package versions with known security advisories, which broke this repository's CI: the code style and static analysis jobs fail installing mediawiki-codesniffer 40, and the MediaWiki 1.39 to 1.42 PHPUnit jobs fail installing MediaWiki itself. This updates mediawiki-codesniffer to 52, applies its new rules with phpcbf, and drops the 1.39 to 1.42 jobs.
Human input
Goal and shape: set by @alistair3149; Claude found the cause and made the changes within that shape.
Outcome: not reviewed by a human yet. Left for you: a skim of the phpcbf changes, and whether extension.json should keep declaring MediaWiki 1.39 as the minimum.
Claude's calls
^52.0.0, so installing the dev tools needs PHP 8.3; the extension itself still needs only PHP 8.0. All phpcbf fixes are kept, including the heredoc closers inWideCsvPresenterTest, whose comma now sits on the next line as the new comma-spacing rule requires.requires.MediaWikiin extension.json to 1.43, a support decision separate from fixing CI; replacing the deprecatedGeneric.Formatting.NoSpaceAfterCastrule in phpcs.xml, which still runs but warns.The change
.github/workflows/ci.yml: the PHPUnit matrix keeps only REL1_43.composer.json: mediawiki-codesniffer^40.0.0→^52.0.0.?DataValue $value = null,catchon the closing-brace line, whitespace).#194 also changes
src/EntryPoints/SpecialWikibaseExport.php, in different lines; either can merge first.Verification evidence
squizlabs/php_codesniffer[3.7.1] … affected by security advisories ("PKSA-rdkp-vv9z-mjkg")); PHPUnit REL1_39 to REL1_42 fail at "Install MediaWiki" (PHPUnit 9.6.16, Guzzle and mediawiki-codesniffer 43 blocked).composer installsucceeds.vendor/bin/phpcsreported 14 errors and 9 warnings in 11 files, all fixed by phpcbf; afterwards it reports none.php -lpasses on every changed file.