[FEAT] : fixed Webhook Redelivery Nested Payload Bug #3155
Open
hrshjswniii wants to merge 3 commits into
Open
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the double-nested payload formatting bug during manual webhook redeliveries. The retry route handler now parses the logged
WebhookPayloaddatabase record and extracts the original innerdatadictionary before re-triggering the dispatch, ensuring the payload structure matches initial dispatch formats.Closes #3128
Type of Change
What Changed
src/app/api/webhooks/custom/[id]/deliveries/[deliveryId]/retry/route.ts):delivery.payload.datablock of theWebhookPayloadwrapper.originalDataparameter todispatchWebhookto prevent nested wrapper replication during retry dispatches.test/webhook-retry-route.test.ts):How to Test
Expected result:
The unit test passes cleanly, confirming the payload extraction.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Additional Context
src/lib/webhooks.tsremains unmodified and clean for standard live events.