Apply limit and offset to GET requests#20
Open
stephangroen wants to merge 11 commits intoPrintNode:masterfrom
Open
Apply limit and offset to GET requests#20stephangroen wants to merge 11 commits intoPrintNode:masterfrom
stephangroen wants to merge 11 commits intoPrintNode:masterfrom
Conversation
emailpassword should be emailPassword
Fixed typo, fixes PrintNode#10
Fix scales API
Adding ability to add options (such as copies)
Author
|
@PrintNodeJames @PrintNodeLtd Any change on merging this? |
3 similar comments
Author
|
@PrintNodeJames @PrintNodeLtd Any change on merging this? |
Author
|
@PrintNodeJames @PrintNodeLtd Any change on merging this? |
Author
|
@PrintNodeJames @PrintNodeLtd Any change on merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a method for applying the limit and offset to requests. This method was never called. Therefor there was never a limit or offset sent to the API and the API always responded based on the defaults.
Example: Getting the printer list always responded with max 100 printers.
This PR calls the
applyOffsetLimitmethod when doing GET requests, so limit and offset get applied correctly.Also made a small fix to declare
$endPointUrlsthe right way, since how it was done is not supported.Tested getting a printer list and applying small limits, combined with an offset which created the right response.