feat(client): add dynamo_chat transport + routed_experts to renderer generate#79
Open
biswapanda wants to merge 25 commits into
Open
feat(client): add dynamo_chat transport + routed_experts to renderer generate#79biswapanda wants to merge 25 commits into
biswapanda wants to merge 25 commits into
Conversation
1 task
…ols from dynamo body, raise on missing ids; rename transport to dynamo_chat
1 task
…d, drop routed_experts on dynamo (codex round 2)
…ake); docstring fix
…erge nvext, canonical completion-ids, logprobs alignment)
…payload to contract
…first-turn stays full)
…trim is now a back-compat fallback
3 tasks
…oid event-loop json.loads)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fec0a81. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds a
dynamo_chattransport to the renderer-basedgenerate()client so it can run against NVIDIA Dynamo, which serves no/inference/v1/generateroute. Selected per-call viatransport=; defaults to the existing vLLM path, so behavior is unchanged unless opted in.Two transports:
vllm_generate(default): unchanged —messages → render_ids() → POST /inference/v1/generate → parse_response()(vLLM TITO surface).dynamo_chat:messages → render_ids() → POST /v1/chat/completionswithnvext.token_data(pre-tokenized prompt) +nvext.extra_fields=["engine_data"]. Completion token IDs and logprobs are read back fromnvext.engine_data.Dynamo wire shape (
_post_dynamo_chat)Mirrors the verifiers token client so the payload is identical whether a rollout goes through the token client or the renderer client.
nvext.token_data(Dynamo skips tokenization when present);cache_salt→nvext.cache_salt,priority→nvext.agent_hints.priority; a single placeholder user message; sampling remap (max_tokens→max_completion_tokens,logprobs=N→logprobs=true+top_logprobs=N); passthrough fields ride the Dynamo allowlist. Tools are baked intotoken_databy the renderer (not sent on the wire).routed_experts (MoE expert replay) — now surfaced on dynamo_chat
(Supersedes the earlier "routed_experts intentionally NOT surfaced" note — it now is.)
parsereads routed_experts fromnvext.routed_experts(ornvext.engine_data.routed_experts) and maps it to the downstreamRoutedExpertsPayload{data, shape, start, dtype}. The Dynamo worker returns full-sequence routing withstart=0; the renderer row-trims the leading prompt rows only when the caller explicitly setsrouted_experts_prompt_start— a first-turn request with no caller start stays full-sequence withstart=0(no phantom prefix). Completion logprobs prefernvext.engine_data.completion_logprobs(the same authoritative source as the engine token IDs) over the chat echo; a present-but-empty engine list is authoritative and does not fall back to chat.Other
RendererTransport = Literal["vllm_generate", "dynamo_chat"]alias. A present-but-emptycompletion_token_idsis a valid zero-token completion; only a fully absent field raises. Multimodal renderers raiseNotImplementedErrorondynamo_chat(vLLM path / token-client TITO remain available for VLMs).Type of Change
Review
Codex adversarial review: SIGN-OFF (F1/F2/F3 + the N1 logprob-presence finding resolved; head
5f2a914). All review threads resolved.Testing
tests/test_client.pycovers the Dynamo request body shape (priority/detokenize/sampling remap), routed_experts parse + row-trim (explicitprompt_startvs first-turn full-sequence), engine-logprob preference incl. present-but-empty, and missing/empty completion IDs.Note
Medium Risk
New Dynamo wire/parse path affects completion IDs, logprobs, and MoE routed_experts for opt-in callers; default vLLM behavior is unchanged but misconfigured Dynamo responses fail at runtime.
Overview
Adds an opt-in
dynamobackend to renderergenerate()via a newtransportargument (defaultvllm), so rollouts can target NVIDIA Dynamo without changing existing vLLM TITO behavior.Wire/parse logic moves into
_VllmGenerateTransportand_DynamoChatTransport, with responses normalized through_WireResult. The Dynamo path posts to/v1/chat/completionswithnvext.token_dataand readsnvext.engine_data.completion_token_ids/ logprobs (engine channel wins over chat echo). It mapscache_salt,priority, androuted_experts_prompt_startintonvext, forwards sampling params via a denylist, and surfacesrouted_expertsvia_normalize_routed_expertsplus optional client-side_trim_dynamo_routed_experts. Large expert blobs use the same zero-copy JSON strip as vLLM (_parse_dynamo_response). Multimodal on Dynamo raisesNotImplementedError.tests/test_client.pyadds broad Dynamo coverage (body shape, nvext merge, errors, logprob alignment, routing trim).Reviewed by Cursor Bugbot for commit b9d25b1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add Dynamo chat-completions transport and
routed_expertssupport togenerate()renderers/client.pywith_VllmGenerateTransport(existing behavior) and_DynamoChatTransport(new) strategies selected via atransportparameter ongenerate()./chat/completionswithnvext.token_data, routescache_saltandpriorityintonvext, mapslogprobsto OpenAI-style fields, and drops vLLM-only keys via a denylist.nvext.engine_dataforcompletion_token_idsandcompletion_logprobs, normalizesrouted_expertsinto a typed struct, and preserves large base64 blobs as zero-copymemoryviewobjects.routed_expertsprompt rows when the worker did not applyrouted_experts_prompt_start.NotImplementedErrorfor multimodal inputs,RuntimeErrorwhen completion IDs are absent or logprobs length mismatches — these are new runtime failure modes with no fallback.Macroscope summarized b9d25b1.