Reduce Performance tab to optional diagnostics

[PrimeBuild-pc]

Summary

• Hide the Performance/Diagnostics entry from primary navigation and the tray by default with AppNavigationOptions.ShowAdvancedDiagnostics = false.
• Remove PerformanceViewModel from MainWindow startup construction; diagnostics now lazy-create the view model only when the diagnostics page is explicitly opened or activated.
• Gate tray CPU/RAM metrics behind ShowAdvancedDiagnostics; hidden diagnostics now show non-performance tray status and do not schedule the lightweight metrics timer.
• Lazily allocate PerformanceMonitoringService performance counters on first metrics use instead of service construction.
• Preserve the existing diagnostics view, snapshots, live metrics command, hotspot list, and create/update rule command for future selected-process diagnostics work.

Tests

• Added diagnostics provider tests proving startup construction does not create PerformanceViewModel and explicit creation is cached.
• Added tray status updater tests proving hidden diagnostics do not resolve/call IPerformanceMonitoringService and do not request lightweight metrics.
• Existing diagnostics ViewModel tests still cover no startup scans, explicit diagnostics activation, stop-on-suspend behavior, and default hidden diagnostics navigation flag.
• dotnet test "ThreadPilot_1.sln" --configuration Release --no-restore passed: 303 passed, 0 failed, 0 skipped.

Limitations / next PR

• The diagnostics route and view remain available internally; this PR only hides primary access by default and removes the hidden startup/tray runtime cost.
• Selected-process diagnostics, CPU affinity changes, memory priority changes, persistent rule changes, versioning, and release notes are intentionally out of scope.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 36.53846% with 132 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
Services/PerformanceMonitoringService.cs	0.00%	33 Missing ⚠️
MainWindow.Behaviors.partial.cs	0.00%	27 Missing ⚠️
Services/SystemTrayStatusUpdater.cs	66.10%	16 Missing and 4 partials ⚠️
Services/SystemTrayService.cs	0.00%	16 Missing ⚠️
ViewModels/PerformanceViewModel.cs	61.53%	11 Missing and 4 partials ⚠️
MainWindow.xaml.cs	0.00%	14 Missing ⚠️
Services/ServiceConfiguration.cs	0.00%	6 Missing ⚠️
ViewModels/DiagnosticsViewModelProvider.cs	80.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[chatgpt-codex-connector]

💡 Codex Review

ThreadPilot/MainWindow.Behaviors.partial.cs

Lines 1467 to 1470 in e1af4d9

	var processViewWillBeActive = tabTag == null
	? this.ProcessManagementTab.Visibility == Visibility.Visible
	: string.Equals(tabTag, "Process", StringComparison.Ordinal);

Apply diagnostics activity state when restoring Diagnostics tab

Update ShowWindowFromTray so that tabTag == "Performance" maps to ForegroundDiagnosticsView instead of falling through to ForegroundOtherTab. In this commit, ForegroundOtherTab now disables diagnostics monitoring, so opening Diagnostics from the tray first activates it in SelectMainTab and then immediately applies the non-diagnostics policy, which suspends the diagnostics session right away.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Continue tray status refreshes when diagnostics are disabled

This early return disables the tray refresh timer in the default configuration (ShowAdvancedDiagnostics == false), and there is no alternate periodic path to call UpdateSystemTrayStatusAsync afterward. That leaves the tray status line stale after startup (for example, after power plan changes), even though the non-diagnostics status still needs current plan information; only CPU/RAM sampling needed to be gated.

Useful? React with 👍 / 👎.