Migrate Process tab manual affinity apply to CpuSelection#16
Conversation
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c2bfc72be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var result = await this.processAffinityApplyCoordinator.ApplyCoreSelectionAsync( | ||
| selectedProcess, | ||
| pendingSelection, | ||
| "Manual Process tab CPU selection"); |
There was a problem hiding this comment.
Avoid showing
0x0 after CPU-set affinity apply
SetAffinity now uses ApplyCoreSelectionAsync, which can return a CPU-sets success result without VerifiedMask populated, but the success branch still formats status/notification using result.VerifiedMask. On systems where CPU Sets are used, users will see a false 0x0 affinity in the success message even though the apply succeeded, which is misleading and can trigger incorrect follow-up actions.
Useful? React with 👍 / 👎.
Summary
Tests
Notes: restore/build emitted existing NU1900 vulnerability-feed warnings because NuGet vulnerability data could not be reached, plus pre-existing StyleCop warnings in LogViewerViewModel.