Global refactor of themes section#2129
Conversation
ga-devfront
left a comment
There was a problem hiding this comment.
Initial feedback: I haven't finished the review yet, but this is to be able to start working on the responses/feedback.
ga-devfront
left a comment
There was a problem hiding this comment.
Second part of my review, it's not finished yet.
40807ec to
d53a6af
Compare
ga-devfront
left a comment
There was a problem hiding this comment.
Please remove all —.
|
@tblivet I'm reviewing 👌🏻 |
|
Hi @kpodemski, did you have time to finish the review? I know it’s a long one 😬 |
kpodemski
left a comment
There was a problem hiding this comment.
Huge work @tblivet @ga-devfront ! I'm leaving a few comments
|
|
||
| [getting-started-guide]: https://docs.prestashop-project.org/v.8-documentation/v/english/getting-started | ||
| [system-requirements]: {{< relref "/9/basics/installation/system-requirements" >}} | ||
| [clone-the-repository]: {{< relref "/9/themes/getting-started/setting-up-your-local-environment" >}} |
There was a problem hiding this comment.
This is used above, right?
| description: Add a widget area above the footer | ||
| ``` | ||
|
|
||
| Modules can also register hooks from PHP using `Hook::register('MyCustomHook')`. See [Hooks]({{< relref "/9/modules/concepts/hooks" >}}) in the module documentation for the full module-side API. |
There was a problem hiding this comment.
| Modules can also register hooks from PHP using `Hook::register('MyCustomHook')`. See [Hooks]({{< relref "/9/modules/concepts/hooks" >}}) in the module documentation for the full module-side API. | |
| Modules can also register hooks from PHP using `Hook::registerHook('MyCustomHook')`. See [Hooks]({{< relref "/9/modules/concepts/hooks" >}}) in the module documentation for the full module-side API. |
| ```smarty | ||
| {l s='%count% items in your cart' d='Shop.Mytheme' sprintf=['%count%' => $cart.products_count]} | ||
| {l s='Welcome, %firstname% %lastname%!' d='Shop.Mytheme' sprintf=['%firstname%' => $customer.firstname, '%lastname%' => $customer.lastname]} | ||
| ``` |
There was a problem hiding this comment.
| ```smarty | |
| {l s='%count% items in your cart' d='Shop.Mytheme' sprintf=['%count%' => $cart.products_count]} | |
| {l s='Welcome, %firstname% %lastname%!' d='Shop.Mytheme' sprintf=['%firstname%' => $customer.firstname, '%lastname%' => $customer.lastname]} | |
| ``` | |
| ```smarty | |
| {l s='%count% items in your cart' d='Shop.Mytheme' sprintf=['%count%' => $cart.products_count]} | |
| {l s='Welcome, %firstname% %lastname%!' d='Shop.Mytheme' sprintf=['%firstname%' => $customer.firstname, '%lastname%' => $customer.lastname]} | |
| {l | |
| s='We noticed a problem with your order. If you think this is an error, feel free to contact our [1]expert customer support team[/1].' | |
| d='Modules.Wirepayment.Shop' sprintf=['[1]' => "<a class='alert-link' href='{$contact_url}'>", '[/1]' => '</a>'] | |
| } |
|
|
||
| # Creating a theme from scratch | ||
|
|
||
| This page covers creating a minimal, valid PrestaShop 9 theme from scratch. It is the recommended starting point for PrestaShop 9.0, and a useful reference for understanding the required file structure on any 9.x version. |
There was a problem hiding this comment.
I disagree. It's not a recommended starting point. In our ecosystem, most of the themes derive from the main theme; for v9, it's Hummingbird.
|
|
||
| {{% children /%}} No newline at end of file | ||
| {{% notice note %}} | ||
| The visual maps are embedded from Figma. If an embed does not load, refer to the hook table below it for the same information. The source Figma file is available in the [Hook Cartography project](https://www.figma.com/file/HKGzVBx5p2JaFrFocGe6p0/Hook-Cartography). |
There was a problem hiding this comment.
It hasn't been updated for a long time, maybe we should mention that we'll try to update it in the future.


Note: a separate PR has been submitted to exclude CLAUDE.md files from the Hugo build: PrestaShop/devdocs-site#44
Sorry for the size of this PR, the nature of a full section refactor made it impossible to split into smaller atomic pieces without losing coherence.