Create lint session for nox #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move black, flake8, and isort actions into the `noxfile.py` alongside the existing mypy session. This will give the dev control over when these checks are run, allowing pre-commit to be optional in the local environment. There is a speed drawback as pre-commit runs on edited files only and nox will run on all file. The pre-commit config will remain and is always an option locally and in pre-commit.ci.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move black, flake8, and isort actions into the
noxfile.pyalongsidethe existing mypy session. This will give the dev control over when
these checks are run, allowing pre-commit to be optional in the local
environment.
Add
nox -s lintsession to run formatters, linters, and type checkingUpdate
lintsession in noxRemove
mypynox sessionblackconfiguration section frompyproject.toml