Repository navigation
feat: emit the Node validation object from Spring and ASP.NET Core - #195
Merged
Merged
Conversation
Spring already reads the live request mappings and an exact OpenAPI document. The snapshot now carries the same disagreement findings, including acknowledgement that keeps the route in the runtime record. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
EndpointDataSource already supplies the live routes and the exact OpenAPI document. The snapshot now carries the same disagreement findings as Node and Spring, including acknowledgement that keeps the route registered. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
bluejeans117
changed the title
FastAPI already reads the live Starlette routes and the generated OpenAPI document. The snapshot now carries the same disagreement findings, including acknowledgement of a route hidden with include_in_schema=False. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
bluejeans117
changed the title
Spring and ASP.NET snapshots now match routes the same way validation does, so parameter names cannot produce an empty finding beside a drift count. Node, Java, and C# share one fixture. FastAPI stays a route snapshot, and the README still describes the published Node release. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
bluejeans117
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validationobject Node emits. Acknowledgement stays informational and does not remove the route. FastAPI stays a route snapshot;include_in_schema=Falseis not treated as a validation failure.matched,runtimeOnly, anddocumentedOnlyuse the same wire identity as validation, so/pets/{id}and/pets/{petId}are one operation.contracts/contract-validation-fixtures.json. The public README still describes the published Node release. Java0.10.0andPrauga.FlexDoc.AspNetCore0.7.0do not contain this object yet.Test plan
mvn -f adapters/java-spring/pom.xml -Dtest=SpringContractValidationConformanceTest,SpringRuntimeIntelligenceTest test