Repository navigation
feat: send an undocumented runtime route from the API Client - #191
Merged
Merged
Conversation
Opening the finding showed the registered method and path and then stopped. The same page now hands that request to the API Client. When the documentation server can execute from the API host, the request prefers that transport. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
Discovered paths already include their mount prefix. Prepending a server URL that also has a base path sent the request to the wrong place, and the configured server hid the origin that registered the route. The URL is now that origin plus the runtime path. The request asks to prefer the API host only when the server has not opted out. A server preferHostExecution of false still selects the browser, the same as a documented operation. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
The handoff records the registering origin as the current server, and the runtime path already includes its mount prefix. Switching to an OpenAPI server whose URL also has that prefix appended the path twice. The switch now keeps a suffix that already starts with the next server's base path. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
Acknowledgement was removing a route from the drift counts so the status could go green. The route stays registered. The finding remains, with disposition acknowledged and info severity, and it does not fail validation. The Node examples acknowledge GET /internal/health and leave POST /internal/reindex unacknowledged so the check still fails. A runtime-only request uses the snapshot origin, or a same-origin path when that origin is absent. It does not borrow an OpenAPI server. The generic server switcher is unchanged. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
The hash listener resolved only spec operations, so opening an undocumented route cleared the page before the contract gap could render. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
POST https://api.example.test/internal/reindexandpreferHostExecution: truewhen the host is available