Repository navigation
feat: open an undocumented runtime route from its finding - #190
Merged
Merged
Conversation
The disagreement check could name a route the service registered and OpenAPI omitted, then leave that finding inert. Opening it now selects the registered route and shows that the service implements it while the contract does not. Sending the request is the next step. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
Opening an undocumented route left the operation view stuck, because the request built for that route was stored once and then treated as proof the next operation did not exist. The view now follows the selected method and path. The runtime-route label is a message, and Tab in the runtime dialog moves to that route and wraps back to close. An undocumented route is an error only when discovery is complete. Partial discovery keeps it a warning. Operators can name intentionally undocumented operations so they are omitted from the finding. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
Acknowledged undocumented routes stay in the full route list and drop out of the drift buckets. summary.runtime now counts matched plus runtime-only routes, so those two numbers add up to the runtime total. The Express, Fastify, and Hono examples acknowledge GET /internal/health, so a complete discovery pass stays green while the route remains visible. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
The Runtime panel renders findings, not the routes array. Acknowledging GET /internal/health removes its finding, so the route is absent from the panel even though snapshot.routes still contains it. Signed-off-by: Vishnu R <vishnurajesh45@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
POST /internal/reindexas a runtime route and still opens documented findings as spec operations