Implement PROC_THREAD_ATTRIBUTE_LIST for handle inheritance#852
Open
tgauth wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Replaces the implicit inherit-all-handles behavior of CreateProcess/CreateProcessAsUser calls in posix_spawn_internal with an explicit allow-list using PROC_THREAD_ATTRIBUTE_HANDLE_LIST, so only the intended stdio and auxiliary handles are inherited by spawned children.
Changes:
- Added
build_inherit_handle_attr_list()helper that constructs and initializes aPROC_THREAD_ATTRIBUTE_LISTfor a given handle set. - Refactored
spawn_child_internal()to accept a caller-ownedSTARTUPINFOEXW*instead of individual stdio handles + internalSTARTUPINFOW. - Updated
posix_spawn_internal()to build the inherit list (stdio + aux fds), setEXTENDED_STARTUPINFO_PRESENT, and clean up the attribute list, with a fall-back to default inheritance if attribute-list setup fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context