Fix detection of Windows PS vs PS Core resolving module directory issues#1974
Open
Borgquite wants to merge 1 commit intoPowerShell:masterfrom
Open
Fix detection of Windows PS vs PS Core resolving module directory issues#1974Borgquite wants to merge 1 commit intoPowerShell:masterfrom
Borgquite wants to merge 1 commit intoPowerShell:masterfrom
Conversation
…ndows PowerShell or PowerShell Core.
Borgquite
requested review from
SydneyhSmith,
adityapatwardhan,
alerickson,
anamnavi and
shammu1
as code owners
Author
|
@microsoft-github-policy-service agree company="Mission Aviation Fellowship International" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix detection of Windows PS vs PS Core resolving module directory issues
PR Context
Switch to using PSEdition instead of Host.Version as running PowerShell under certain instances does not return correct version (e.g. VSCode, .NET Interactive, Ruby/Puppet)
The PSEdition variable returns $null, or 'Desktop' under Windows PowerShell, and 'Core' under PowerShell Core. The code therefore checks for 'Core' to determine if Core is in use - otherwise, it determines Windows PowerShell.
https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_powershell_editions?view=powershell-7.5
This is the method preferred by the PowerShell team for identifying the use of PowerShell Core, rather than using version numbers
https://devblogs.microsoft.com/scripting/powertip-identify-if-you-are-running-on-powershell-core/
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.