win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password by mimachniak · Pull Request #1308 · PowerShell/DSC

mimachniak · 2025-12-08T22:15:46Z

PR Summary

I change creating object System.Management.Automation.PSCredential for ScriptBase resources base on Get-Credential parameters
Added dsc.yaml test file for ScriptBased DSC

PR Context

Fix using ScriptBased DSC resources when is reguired to use parameters with Get-Credentials

…aials

…nvert to System.Management.Automation.PSCredentia

mimachniak · 2025-12-09T06:38:35Z

@microsoft-github-policy-service agree

@mimachniak please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

Gijsreyn · 2025-12-14T07:38:13Z

@mimachniak - as I have already spoken with you on socials, is this perhaps also possible for class-based DSC resources (both in the 5.1 and 7.0 adapter)? Can you also include a testcase that covers this change?

mimachniak · 2025-12-14T13:09:06Z

Yes I working o it

…x-ScriptDSC

…rt to System.Management.Automation.PSCredentia - code optimalization remove unused function

…tem.Management.Automation.PSCredential

…meters

…t to System.Management.Automation.PSCredential

…t to System.Management.Automation.PSCredential - if change to recognize user information

mimachniak · 2025-12-18T09:58:40Z

@Gijsreyn , @SteveL-MSFT - I added in test folder yaml's that are using TestClass for validation using PSCredentials, I tested on version 5.1 and 7 of PowerShell

Gijsreyn · 2025-12-21T03:32:04Z

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

mimachniak · 2025-12-21T09:37:10Z

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

I will add today, I added yaml files for running test

…alid secure object

mimachniak · 2025-12-21T21:45:22Z

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

I added unit test and validation in file in powershellgroup.config.tests.ps1

…d secure object

mimachniak · 2025-12-22T21:36:15Z

I added test for 5.1 as well

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

SteveL-MSFT · 2026-01-12T18:12:43Z

@mimachniak Thanks for adding the test resource, but there isn't a Pester test using it yet?

mimachniak · 2026-01-12T18:51:37Z

@SteveL-MSFT I will add test today

…sc for script resources

… parameters - credentials

mimachniak · 2026-02-23T22:25:13Z

@SteveL-MSFT can you approve marge ?

adapters/powershell/psDscAdapter/psDscAdapter.psm1

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 18 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...wershell/Tests/TestScriptBaseDSC/DSCResources/CredentialValidation/CredentialValidation.psm1

adapters/powershell/Tests/win_powershellgroup.tests.ps1

adapters/powershell/psDscAdapter/psDscAdapter.psm1

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

adapters/powershell/psDscAdapter/psDscAdapter.psm1

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

adapters/powershell/Tests/class_ps_resources_secret.parameters.yaml

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

….yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ntialValidation/CredentialValidation.psm1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ntialValidation/CredentialValidation.psm1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…th 'Username' and 'Password' properties

…ject'] -and

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mimachniak · 2026-02-27T19:20:03Z

@copilot open a new pull request to apply changes based on the comments in this thread

mimachniak · 2026-02-27T19:56:04Z

@SteveL-MSFT - all copilot suggestion resolved but this warring don't appear in .12 version so test cannot add this Validating deprecation warning for adapter 'Microsoft.Adapter/WindowsPowerShell'

mimachniak · 2026-02-28T19:05:33Z

@SteveL-MSFT I update branch because linux build faild I see you add some fix, please allow to run

mimachniak added 2 commits December 8, 2025 22:45

Add to win_psDscAdapter function for extraxting string from PSCredent…

61f4b85

…aials

Add to win_psDscAdapter for ScriptBase resources PSCredentails fix co…

cd5df41

…nvert to System.Management.Automation.PSCredentia

Gijsreyn reviewed Dec 14, 2025

View reviewed changes

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1 Outdated Show resolved Hide resolved

mimachniak and others added 3 commits December 17, 2025 16:26

Merge branch 'PowerShell:main' into win_psDscAdapter-PSCredentials-fi…

98e7099

…x-ScriptDSC

Fix win_psDscAdapter for ScriptBase resources PSCredentails fix conve…

0a7c6aa

…rt to System.Management.Automation.PSCredentia - code optimalization remove unused function

psDscAdapter for ClassBase resources PSCredentails fix convert to Sys…

82aeec4

…tem.Management.Automation.PSCredential

mimachniak changed the title ~~Win ps dsc adapter ps credentials fix script dsc~~ win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password Dec 18, 2025

mimachniak added 3 commits December 18, 2025 10:30

Add for testClass testing yaml with secureObject - main file and para…

506ba9f

…meters

Fix win_psDscAdapter for ClassBase resources PSCredentails fix conver…

49c381c

…t to System.Management.Automation.PSCredential

Fix win_psDscAdapter for ClassBase resources PSCredentails fix conver…

403e6b5

…t to System.Management.Automation.PSCredential - if change to recognize user information

Ad unit test for credentaials in powershellgroup.config.tests.ps1 - v…

352dd69

…alid secure object

mimachniak added 2 commits December 22, 2025 22:30

Ad unit test for credentaials in win_powershellgroup.tests.ps1 - vali…

4af004e

…d secure object

Ad unit test for credentaials in win_powershellgroup.tests.ps1 - vali…

dd7425e

…d secure object

SteveL-MSFT requested changes Jan 7, 2026

View reviewed changes

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1 Outdated Show resolved Hide resolved

Add script base DSC resources for testing credentials

b8cff4a

johlju mentioned this pull request Jan 12, 2026

SqlDatabase: Error: JSON: expected value at line 1 column 1 dsccommunity/SqlServerDsc#2403

Closed

mimachniak added 4 commits January 13, 2026 00:21

Add script base DSC resources for testing credentials and fix win_PsD…

63cd935

…sc for script resources

Script base yaml DSC resources for credential valid

73dacde

Add script base resource test in win_powershellgroup.tests.ps1

34b6b73

Add to win_psDscAdapter.psm1 support for secure object and test value…

877ee8b

… parameters - credentials

SteveL-MSFT requested changes Feb 25, 2026

View reviewed changes

adapters/powershell/psDscAdapter/psDscAdapter.psm1 Show resolved Hide resolved

SteveL-MSFT requested a review from Copilot February 25, 2026 04:48

Copilot started reviewing on behalf of SteveL-MSFT February 25, 2026 04:49 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

mimachniak and others added 18 commits February 25, 2026 22:19

Update adapters/powershell/Tests/class_ps_resources_secret.parameters…

c71240f

….yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/Tests/win_powershellgroup.tests.ps1

35613e2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

466a595

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/Tests/TestScriptBaseDSC/DSCResources/Crede…

3ea45e9

…ntialValidation/CredentialValidation.psm1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into win_psDscAdapter-PSCredentials-fix-ScriptDSC

76a8990

Update adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

aff99b5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

67717e0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/Tests/TestScriptBaseDSC/DSCResources/Crede…

1397b2e

…ntialValidation/CredentialValidation.psm1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

6cbe62e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update adapters/powershell/Tests/win_powershellgroup.tests.ps1

d2d3d1c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove case sensitive issue for display Credential object requires bo…

c3b118d

…th 'Username' and 'Password' properties

Add suggestion for secure object .Value.PSObject.Properties['secureOb…

99da2c8

…ject'] -and

Add suggestion for secure object .Value.PSObject.Properties['secureOb…

2823483

…ject'] -and

Update adapters/powershell/Tests/win_powershellgroup.tests.ps1

2826fba

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into win_psDscAdapter-PSCredentials-fix-ScriptDSC

1ea2346

Update adapters/powershell/Tests/win_powershellgroup.tests.ps1

753c301

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove throw - in dsc class

28d5b3d

Remove throw - in dsc class

1418dfa

mimachniak closed this Feb 27, 2026

mimachniak reopened this Feb 27, 2026

Test resolved - to pass

e624d82

Merge branch 'main' into win_psDscAdapter-PSCredentials-fix-ScriptDSC

8cc64e8

Conversation

mimachniak commented Dec 8, 2025

PR Summary

PR Context

Uh oh!

mimachniak commented Dec 9, 2025

Uh oh!

Uh oh!

Gijsreyn commented Dec 14, 2025

Uh oh!

mimachniak commented Dec 14, 2025

Uh oh!

mimachniak commented Dec 18, 2025

Uh oh!

Gijsreyn commented Dec 21, 2025

Uh oh!

mimachniak commented Dec 21, 2025

Uh oh!

mimachniak commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mimachniak commented Dec 22, 2025

Uh oh!

Uh oh!

SteveL-MSFT commented Jan 12, 2026

Uh oh!

mimachniak commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mimachniak commented Feb 23, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mimachniak commented Feb 27, 2026

Uh oh!

mimachniak commented Feb 27, 2026

Uh oh!

mimachniak commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mimachniak commented Dec 21, 2025 •

edited

Loading

mimachniak commented Jan 12, 2026 •

edited

Loading