Skip to content

Add test coverage for order-sensitive ON_ERROR_STOP check #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnasbyupgrade wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test coverage for order-sensitive ON_ERROR_STOP check #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/standard/check-test-install-error-stop-script.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,22 @@ setup() {
assert_success
}

@test "check-test-install-error-stop.sh: passes when ON_ERROR_STOP is explicitly turned on then off" {
printf '\\set ON_ERROR_STOP on\nCREATE TABLE foo AS SELECT 1;\n\\set ON_ERROR_STOP off\n' > "$TESTDIR/install/foo.sql"

run "$SCRIPT" "$TESTDIR"
assert_success
}

@test "check-test-install-error-stop.sh: fails when ON_ERROR_STOP is only ever turned off" {
printf '\\set ON_ERROR_STOP off\nCREATE TABLE foo AS SELECT 1;\n' > "$TESTDIR/install/foo.sql"

run "$SCRIPT" "$TESTDIR"
assert_failure_with_status 1
assert_contains "$output" "foo.sql"
assert_contains "$output" "ON_ERROR_STOP"
}

@test "check-test-install-error-stop.sh: fails when a file has neither" {
printf 'CREATE TABLE foo AS SELECT 1;\n' > "$TESTDIR/install/foo.sql"

Expand Down