CI: bump actions/checkout to v7 (v4 targets Node.js 20, now deprecated) - #42
CI: bump actions/checkout to v7 (v4 targets Node.js 20, now deprecated)#42jnasbyupgrade wants to merge 1 commit into
Conversation
GitHub Actions runners have started warning that Node.js 20 is deprecated and actions pinned to it are being forced onto Node.js 24 at runtime. actions/checkout@v4 is one of those; v7 is the current latest major and already targets Node 24 natively. anthropics/claude-code-action is already on its latest major (v1, no v2 exists yet) so it's untouched. v7 also added a default-deny guard: it refuses to check out a fork's PR head when the trigger is pull_request_target or workflow_run (the classic "pwn request" pattern), unless allow-unsafe-pr-checkout: true is set. claude-code-review.yml's "Check out PR head" step does exactly that under pull_request_target, so it needed the explicit opt-in to keep working - already safe here per the guards documented at the top of that workflow (gated to jnasbyupgrade's own PRs, persist-credentials: false, checked-out code only ever read for review context, never built or executed). The other two checkout call sites (ci.yml x3, claude.yml) just check out this repo's own ref and needed no such change. No local way to confirm the deprecation warning itself is gone - that only shows up in real Actions run logs, not anything checkable from a clone. Needs a real CI run on this PR to confirm.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @jnasbyupgrade's task in 1m 45s —— View job Code Review: CI: bump actions/checkout to v7
SummaryClean, well-scoped maintenance change. All 5 I verified the other 4 sites don't need the opt-in:
The added Notes (non-blocking)
No bugs or security issues found; nothing to change. |
GitHub Actions runners have started warning that Node.js 20 is deprecated and actions pinned to it are being forced onto Node.js 24 at runtime. actions/checkout@v4 is one of those; v7 is the current latest major and already targets Node 24 natively. anthropics/claude-code-action is already on its latest major (v1, no v2 exists yet) so it's untouched.
v7 also added a default-deny guard: it refuses to check out a fork's PR head when the trigger is pull_request_target or workflow_run (the classic "pwn request" pattern), unless allow-unsafe-pr-checkout: true is set. claude-code-review.yml's "Check out PR head" step does exactly that under pull_request_target, so it needed the explicit opt-in to keep working - already safe here per the guards documented at the top of that workflow (gated to jnasbyupgrade's own PRs, persist-credentials: false, checked-out code only ever read for review context, never built or executed). The other two checkout call sites (ci.yml x3, claude.yml) just check out this repo's own ref and needed no such change.
No local way to confirm the deprecation warning itself is gone - that only shows up in real Actions run logs, not anything checkable from a clone. Needs a real CI run on this PR to confirm.