Skip to content

Fix claude-code-review.yml trust gate: check PR author, not head repo owner #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnasbyupgrade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix claude-code-review.yml trust gate: check PR author, not head repo owner #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@ concurrency:

jobs:
claude-review:
# Trusted fork only, and skip drafts (don't spend API/CI on unfinished PRs).
# To add more trusted owners, extend the head-owner check.
# Trusted author only, and skip drafts (don't spend API/CI on unfinished PRs).
# To add more trusted authors, extend the author check.
#
# SECURITY-CRITICAL: this owner check is the ONLY thing that makes
# SECURITY-CRITICAL: this author check is the ONLY thing that makes
# `allow-unsafe-pr-checkout: true` below acceptable. Without it, this
# pull_request_target job would check out and let Claude act on
# arbitrary fork code while holding base-repo secrets/token — a "pwn
# request". Do not remove or loosen this condition (e.g. drop the
# owner check, or allow non-owner forks) without re-evaluating the
# author check, or allow untrusted authors) without re-evaluating the
# fork-checkout step's safety.
if: >-
github.event.pull_request.draft == false &&
github.event.pull_request.head.repo.owner.login == 'jnasbyupgrade'
github.event.pull_request.user.login == 'jnasbyupgrade'
runs-on: ubuntu-latest
timeout-minutes: 60
permissions:
Expand Down