Pin cat_tools to the 0.3.0 tag now that it exists - #25
Open
jnasbyupgrade wants to merge 1 commit into
Open
Conversation
cat_tools 0.3.0 was just tagged on GitHub (Postgres-Extensions/cat_tools), where before there was only a floating master branch to track (0.3.0 hadn't been tagged yet when the git-source install was added). The tag's commit is identical to the master tip this was already tracking, so this is a pure reference-stability improvement, not a behavior change: point CAT_TOOLS_GIT_REF at the tag instead of the moving master branch. This still does not unblock cutting a real extension_drop PGXN release -- cat_tools 0.3.0 is tagged on GitHub but still not published to PGXN, and RELEASE.md requires the real thing for that. The exit condition from the original fix (pgxn install 'cat_tools>=0.3.0' once it's actually on PGXN) still stands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to #10. cat_tools 0.3.0 has just been tagged on GitHub
(
Postgres-Extensions/cat_tools) — before this,fix-cat-tools-install'sCAT_TOOLS_GIT_REFhad already moved past its original raw-SHA pin totracking
masterdirectly (seebaf0a6e), since 0.3.0 hadn't been taggedyet and there was nothing more stable to point at.
Now that a real tag exists, this re-points
CAT_TOOLS_GIT_REFat0.3.0instead of the moving
masterbranch. Checked first: the0.3.0tag'scommit (
5fa8083d...) is identical to cat_tools' currentmastertip, sothis is a pure reference-stability change — same commit, just a fixed,
intentional name instead of a moving branch pointer — not a behavior
change. No regression check across a range was needed since there's no
delta between the two refs.
This does NOT unblock cutting a real extension_drop PGXN release.
cat_tools 0.3.0 is tagged on GitHub but still not published to PGXN
Manager, and
RELEASE.md's rule is that a dependency pinned to a gitsource (rather than genuinely
pgxn install-able) blocks a release. Theoriginal fix's exit condition — revert to a plain
pgxn install 'cat_tools>=0.3.0' --sudoonce it's actually on PGXN — stillstands and hasn't been reached.
What changed
Makefile:CAT_TOOLS_GIT_REFchanged frommasterto0.3.0, commentupdated to describe the tag now existing and reiterate the
does-not-unblock-release caveat.
Test plan
make cat_toolsfrom a clean state (removed the installedcat_tools.control/sql files first) — clone +git checkout 0.3.0+install succeeded.
default_versionin the installedcat_tools.controlresolves to
0.3.0, same as before.make installandmake test:schemaandsimplepass.zzz_buildfails, but that's pre-existing and unrelated —
test/expected/zzz_build.outhasn't changed since the initial commit, and the diff is PG17 emitting
new
%TYPE-reference NOTICE messages inextension_drop.sqlitself,nothing to do with cat_tools or this change.
🤖 Generated with Claude Code