feat: start and stop integrations on opt out#438
feat: start and stop integrations on opt out#438MohitMandalia wants to merge 5 commits intoPostHog:mainfrom
Conversation
847c6ef to
3fc6d8f
Compare
3fc6d8f to
ccdfabe
Compare
|
not all integrations should be uninstalled/installed again |
Yup got it, no worries I will take some time to read through and discuss until its ready. |
A similar concern must be for iOS as well PostHog/posthog-ios#280 if not better to check maybe. |
|
@marandaneto Can we define the main goal of this PR? Based on what I think there are few implementations which should not be uninstalled: Ok to Uninstall:
should not Uninstall:
|
sorry busy with other things this week, will take a look next week |
No worries take your time. I would be posting whatever questions I have.
|
@MohitMandalia iOS is okay for PostHogAppInstallIntegration since we depend on a static var to avoid capturing duplicate events. |
💡 Motivation and Context
Closes #242
💚 How did you test it?
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file