chore: use dominant/average color instead of just black#401
Draft
marandaneto wants to merge 1 commit intomainfrom
Draft
chore: use dominant/average color instead of just black#401marandaneto wants to merge 1 commit intomainfrom
marandaneto wants to merge 1 commit intomainfrom
Conversation
Contributor
Instructions and example for changelogPlease add an entry to the appropriate changelog:
Make sure the entry includes this PR's number. ## Next
- use dominant/average color instead of just black ([#401](https://github.com/PostHog/posthog-android/pull/401))If none of the above apply, you can opt out of this check by adding |
marandaneto
commented
Jan 29, 2026
| android:id="@+id/imvAndroid" | ||
| android:layout_width="150dp" | ||
| android:layout_height="150dp" | ||
| android:src="@drawable/android_logo" |
Member
Author
There was a problem hiding this comment.
android logo is green ish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
just a POC since it does not work well all the cases
eg if the doninant color is white and the background is white, its masked but you actually dont know there was something there eventhough the text color was red
💚 How did you test it?
📝 Checklist