Skip to content

fix: compact Bind storage and terminal portal release#960

Open
bill-ph wants to merge 2 commits into
mainfrom
codex/controlplane-bind-oom
Open

fix: compact Bind storage and terminal portal release#960
bill-ph wants to merge 2 commits into
mainfrom
codex/controlplane-bind-oom

Conversation

@bill-ph

@bill-ph bill-ph commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • retain each Bind frame once with compact parameter offsets
  • interpolate text Bind values directly into Flight SQL without per-value Go strings or interfaces
  • release terminal portal payloads and prepared-statement references while retaining cached RowDescription for Describe(P)

Follow-ups

  • binary Bind allocation optimization
  • per-connection guardrails and observability
  • process-wide retained/in-flight memory admission
  • transaction-aware Sync/transaction-end cleanup
  • safe mutation result-format validation
  • Execute(maxRows) fail-closed behavior and eventual PortalSuspended support

Validation

  • go test ./server ./server/flightclient ./server/sqlcore
  • go test -race ./server -run 'TestPortalLifecycle'
  • go test ./server -run '^$' -bench '^(BenchmarkHandleBind27000Params|BenchmarkBindToFlightInterpolation27000Params)$' -benchmem
  • just lint
  • git diff --check

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Test Impact Plan

Deterministic summary of how this PR changes tests, CI runners, and coverage-risk signals.

Summary

Area Added Changed Deleted
Test files 0 5 0
E2E/journey files 0 0 0
Workflow files 0 0 0

Signals

  • Test cases: +15 / -0
  • Assertions: +92 / -3
  • Skips or known failures added: 0
  • Workflow continue-on-error added: 0
  • Workflow path filters added: 0
  • Test commands removed from justfile: 0
  • E2E/journey retry lines added: 0

Coverage risk: neutral or increased

No coverage-reduction warnings detected.

@bill-ph
bill-ph marked this pull request as ready for review July 15, 2026 18:37
Comment thread server/sqlcore/result_column_count.go Fixed
@bill-ph
bill-ph force-pushed the codex/controlplane-bind-oom branch from ec5ceb6 to 2b2faa3 Compare July 16, 2026 14:41
@bill-ph bill-ph changed the title fix: compact retained Bind portal memory fix: compact Bind storage and terminal portal release Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants