fix: dial scenario PGWire directly with SNI#932
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/pqconnector dialer for both scenario SQL and perf PGWire clients instead of the unsupported DSNhostaddrsettingPGHOSTADDRbehavior and document the explicit transport splitRoot cause
The Go
lib/pqdriver resolveshostfor TCP dialing and does not implement libpqhostaddrsemantics. The scenario hostname is intentionally not resolvable, so SQL and perf failed before reaching the control plane.Validation
go test -count=1 ./tests/mw-dev/scenario/... ./tests/mw-dev ./tests/perf/drivers/pgwirejust lintThe direct-dial regression test uses an unresolvable SNI hostname and a local TCP listener, proving that the connection reaches the direct address while TLS still carries the expected SNI.