Skip to content

perf(code): make task composer repo/branch selectors feel instant #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fercgomes wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −10
Open

perf(code): make task composer repo/branch selectors feel instant #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/code/src/renderer/features/git-interaction/components/BranchSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export function BranchSelector({
useQuery(
trpc.git.getAllBranches.queryOptions(
{ directoryPath: repoPath as string },
{ enabled: !isCloudMode && !!repoPath && open, staleTime: 10_000 },
{ enabled: !isCloudMode && !!repoPath, staleTime: 60_000 },
),
);

Expand Down
9 changes: 0 additions & 9 deletions apps/code/src/renderer/features/task-detail/components/TaskInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ export function TaskInput({
const [cloudRepoSearchQuery, setCloudRepoSearchQuery] = useState("");
const [isCloudRepoPickerOpen, setIsCloudRepoPickerOpen] = useState(false);
const [cloudBranchSearchQuery, setCloudBranchSearchQuery] = useState("");
const [isCloudBranchPickerOpen, setIsCloudBranchPickerOpen] = useState(false);
const [selectedEnvironment, setSelectedEnvironmentRaw] = useState<
string | null
>(null);
Expand Down Expand Up @@ -244,7 +243,6 @@ export function TaskInput({
selectedInstallationId,
selectedCloudRepository,
cloudBranchSearchQuery,
isCloudBranchPickerOpen,
);
const cloudBranches = cloudBranchData?.branches;
const cloudDefaultBranch = cloudBranchData?.defaultBranch ?? null;
Expand Down Expand Up @@ -324,10 +322,6 @@ export function TaskInput({
});
}, [refreshCloudBranches]);

const handleCloudBranchPickerOpen = useCallback(() => {
setIsCloudBranchPickerOpen(true);
}, []);

const handleCloudRepoPickerOpenChange = useCallback((open: boolean) => {
setIsCloudRepoPickerOpen(open);
if (!open) {
Expand All @@ -344,7 +338,6 @@ export function TaskInput({
}, [loadMoreCloudRepositories]);

const handleCloudBranchPickerClose = useCallback(() => {
setIsCloudBranchPickerOpen(false);
setCloudBranchSearchQuery("");
}, []);

Expand Down Expand Up @@ -414,7 +407,6 @@ export function TaskInput({

useEffect(() => {
setCloudBranchSearchQuery("");
setIsCloudBranchPickerOpen(false);
}, []);

const effectiveRepoPath =
Expand Down Expand Up @@ -717,7 +709,6 @@ export function TaskInput({
cloudBranchesFetchingMore={cloudBranchesFetchingMore}
cloudBranchesHasMore={cloudBranchesHasMore}
cloudSearchQuery={cloudBranchSearchQuery}
onCloudPickerOpen={handleCloudBranchPickerOpen}
onCloudPickerClose={handleCloudBranchPickerClose}
onCloudSearchChange={handleCloudBranchSearchChange}
onCloudLoadMore={handleLoadMoreCloudBranches}
Expand Down
2 changes: 2 additions & 0 deletions apps/code/src/renderer/hooks/useIntegrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ export function useGithubBranches(
if (!lastPage.hasMore) return undefined;
return allPages.reduce((n, p) => n + p.branches.length, 0);
},
staleTime: 5 * 60 * 1000,
},
);

Expand Down Expand Up @@ -460,6 +461,7 @@ export function useUserGithubBranches(
if (!lastPage.hasMore) return undefined;
return allPages.reduce((n, p) => n + p.branches.length, 0);
},
staleTime: 5 * 60 * 1000,
},
);

Expand Down
Loading