Repository navigation
fix: complete activity history filter types - #17
Open
harley-poly wants to merge 1 commit into
Open
harley-poly wants to merge 1 commit into
harley-poly wants to merge 1 commit into
Conversation
watashi
pushed a commit
to watashi/polymarket-us-python
that referenced
this pull request
Oct 12, 2026
…ient build: rename package to polymarket-client
poly-william
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add the missing
startTimeandendTimefilters toGetActivitiesParams, and taker-fee-rebate and liquidity-program values toActivityType. These already work at runtime; typed callers can now use them without bypassing the SDK annotations.Include a filtering example with time-bound and pagination semantics. Set the patch version to 2.4.2. Follows the gateway contracts in https://github.com/Polymarket/go-gateway-us/pull/890 and https://github.com/Polymarket/go-gateway-us/commit/a1cf438ca20c24aa35fb9547365b15143b735438.
Testing
Checklist
pytest)ruff check .)mypy polymarket_us)Note
Low Risk
Annotation and documentation updates only; runtime request behavior is unchanged and covered by new pass-through tests.
Overview
Aligns portfolio activity history typings and docs with filters the API already accepts.
GetActivitiesParamsnow includes optionalstartTimeandendTime(RFC 3339), andActivityTypeaddsACTIVITY_TYPE_TAKER_FEE_REBATEandACTIVITY_TYPE_LIQUIDITY_PROGRAM. Typed callers no longer need workarounds for time bounds or reward categories. The README documents filtering, inclusive endpoints, ordering rules, and cursor pagination for sync and async clients.Adds parametrized HTTP mock tests so sync/async
portfolio.activitiesforwards query params unchanged (including listtypesand timestamp precision). Patch release 2.4.2.Reviewed by Cursor Bugbot for commit fcabeba. Bugbot is set up for automated code reviews on this repo. Configure here.