fix: stabilize incremental inference and index ownership - #89
Open
Pollux12 wants to merge 160 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
glua_code_analysisfor declaration inference, member ownership, flow narrowing, type checks, diagnostics, and incremental edits.glua_lsand isolated progress tests from concurrent analysis.Greptile Summary
This PR substantially reworks incremental inference, index ownership, cache invalidation, and LSP analysis coordination to keep semantic results stable across edits and re-analysis.
Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Edit[Workspace edit] --> VFS[VFS and position mapping] VFS --> Reindex[Partial re-index] Reindex --> Ownership[Member and declaration ownership] Ownership --> Infer[Incremental inference] Infer --> Cache[Dependent cache invalidation] Cache --> Semantic[Semantic snapshot] Semantic --> LSP[Diagnostics, completion, hover]Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/index-regre..." | Re-trigger Greptile