Repository navigation
Async actions: capture() and when() - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2, step A (design doc, "Capturing values at trigger time").
capture()UnexpectedValueException.Captured value 'request' cannot be carried…). An object travels by reference and is reloaded at execution; to keep its trigger-time state, capture a scalar (tested).capture()method is used automatically whencapture()is not called (design doc).capture()on the registration wins over it.when()true(strictly: a truthy value does not count).Also
ArgumentNormalizer::normalize()takes the kind of value, for error messages.RecordingDrivertest fixture, shared by the async tests.Tests
164 passed, 12 new. PHPStan level 5 and Pint pass.