Repository navigation
Async actions: defaults, parameter injection, failures thrown to the queue (v1.4.0) - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the framework needs for Async Actions phase 3, released as v1.4.0.
Async::setDefaults(tries:, backoff:, asUser:)The options every registration starts from, validated like
tries()andbackoff(). The framework will set them fromconfig/hooks.php(tries,as_user,queue.backoffin the design doc). Chained options still override them.Async::injectParametersUsing($resolver, ?$isInjectable)Design doc: "the other typed parameters are injected by the container". Opt-in: without a resolver nothing changes.
JsonSerializableandAsyncContextstay hook arguments. A predicate can replace that rule.hookArgumentCount()), so they can sit anywhere.send(int $postId, Mailer $mailer, AsyncContext $context, ?WP_Post $post = null)registers for 2 hook arguments.Async::receive($message, throwOnFinalFailure: true)For the framework's
RunAsyncActionjob. The last failure is fired aspollora/async/failed, then thrown instead of reported, so the Laravel queue records it infailed_jobsand logs it once. Retries still happen while attempts are left; a deleted referenced object is still dropped silently; a missing handler or an unreadable payload throws.Tests
254 passed, 20 new. The real-WordPress suite (18) still passes. PHPStan level 5 and Pint pass. The CHANGELOG is dated 1.4.0, and the README gains a "Dependencies" paragraph.