Repository navigation
Async actions: unique() - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2, step C:
unique().Identical triggers (same hook, same handler, same normalized arguments) are merged while the first one has not started running.
The lock (
UniqueLock)pollora_unique_{sha1}, not autoloaded, holding its expiry time.add_option(): the unique key onoption_namelets only one process create it. An expired lock is taken over the same way: delete, thenadd_option(), so of two processes only one wins.pollora/async/recover), which taking a lock schedules.Cost: one write at trigger time, plus one read when the lock exists, as the design doc states.
Tests
195 passed, 12 new: merging, autoload flag and expiry, release at first attempt, expired takeover, hook and handler told apart, retry versus newer lock, release on queuing failure, sync driver, storage failure, pruning, 1.2.0 payloads. The real-WordPress suite passes. PHPStan level 5 and Pint pass.