Repository navigation
Async actions: tries(), backoff(), asUser(), onQueue() - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2, step B: retries, original user, queue name.
tries()andbackoff()attempt + 1, after the delay for that attempt.Attempt 1 of 3 failed, retried in 10 s: …). The last failure is reported and fired aspollora/async/failed, as before.backoff()default is[10, 60, 300], the values planned for the framework'sconfig/hooks.php; the last value repeats. Invalid values (tries(0), empty or negative backoff) throwInvalidArgumentExceptionat registration.sync: retries happen at once, nested.asUser()Runs the handler as the user who fired the hook, then switches back to the previous user, always in a
finally. Order: site, then user (capabilities depend on the site), then locale; restored in reverse. Without it, the handler runs with no current user, the safe default; the ID stays readable in the context. Nothing is switched when nobody was logged in.onQueue()Records the queue name in the payload: the group for Action Scheduler (next PRs) and the queue for the framework's Laravel driver. WP-Cron ignores it.
Payload
New fields
driver,queue,asUser,backoff. Optional on read, so payloads queued by 1.2.0 still run (tested).backoffis validated when read back.Tests
183 passed, 19 new. The real-WordPress suite still passes. PHPStan level 5 and Pint pass.