Repository navigation
refactor: require pollora/attributes instead of shipping the attributes - #463
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of the
pollora/attributesextraction, after #462. The attributes now come frompollora/attributes(v0.1.0), which the framework requires as^0.1 || ^1.0. No class name changes.What moves
src/Attributes/*(112 files) and the value types the attributes take:Pollora\Schedule\Every,Interval,Pollora\Role\Domain\Enums\Access,Pollora\Meta\Domain\Enums\Control,Pollora\BlockBinding\Domain\Enums\BindingFieldType. The package declares these under their exact namespaces; Composer still finds the framework's other classes of those namespaces insrc/.HookTest,PostTypeAttributeTest,PostTypeSubAttributesTest,ScheduleTest,TaxonomySubAttributesTest,NamingTest,ArchitectureTest,EveryTest,IntervalTest), now in the package with a test of what each attribute contributes.What stays
PostTypeAttributeandTaxonomyAttribute(they need the framework's interfaces), and every discovery that reads the attributes.#[SkipDiscovery]stays inpollora/discovery.pollora/attributesrequirespollora/ajaxandpollora/abilitiesforAjaxAccessandBehaviour; both depend on PHP alone.SlugTestadded:Pollora\Support\Slugdelegates to the package's naming helper, whose parity test moved with it.Checks
Against the package as a path repository: 1878 tests (1975 before, 97 moved to the package, which runs 114), PHPStan 0, type coverage 99.1 %.
CI needs
pollora/attributeson Packagist to install; it is re-run once the package is indexed.