Fix North Dakota 2026 income tax thresholds - #9165
Conversation
|
@MaxGhenis This is ready for maintainer review: exact head |
Program Review — PR #9165 (Fix North Dakota 2026 income tax thresholds)Author: PavelMakarchuk Source Documents
Branch Status⚠ 6 commits behind main (1 ahead). Minor; review scoped to the merge-base diff. SummaryClean, correct TY2026 value update across all five filing statuses. 0 critical. Every 2026 bracket threshold matches ND-1ES 2026 p.2 exactly, correctly routed to the right status, correctly dated at PDF / value audit — all 10 thresholds match ND-1ES 2026 p.2
Base-amount cross-checks reproduce the form's printed "your tax is" column exactly ((250,400−49,575)×0.0195 = $3,916.09; MFJ $4,329.98; separate $2,164.99; HoH $4,118.40). MFJ and QSS correctly share one schedule per the form; no status file received another's thresholds; CriticalNone. Should Address (minor / cosmetic)
Suggestions (optional)
Validation Summary
Review Severity: APPROVEAn exemplary, fully-verified 2026 multi-status threshold update: every value matched against ND-1ES 2026 p.2 with base-amount cross-checks, correct MFJ/QSS sharing, and comprehensive per-status boundary tests. No functional issues — only a cosmetic reference-title wording fix and a pre-existing trailing-zero cleanup. Rebase off the 6-commit lag before merge. Review generated with Claude Code via /review-program |
Summary
Source
North Dakota Office of State Tax Commissioner, 2026 Form ND-1ES, page 2.
Checks
make format(includes Ruff formatting and lint)uv run pytest -c pyproject.toml policyengine_us/tests/core/test_state_indexed_frozen_parameters.py -k nd -q(32 passed)uv run pytest -c pyproject.toml policyengine_us/tests/test_parameter_files.py -q(6 passed)