Add statute-facing taxpayer ID primitives#7974
Open
MaxGhenis wants to merge 2 commits intoPolicyEngine:mainfrom
Open
Add statute-facing taxpayer ID primitives#7974MaxGhenis wants to merge 2 commits intoPolicyEngine:mainfrom
MaxGhenis wants to merge 2 commits intoPolicyEngine:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7974 +/- ##
===========================================
- Coverage 100.00% 93.66% -6.34%
===========================================
Files 1 10 +9
Lines 13 142 +129
Branches 0 8 +8
===========================================
+ Hits 13 133 +120
- Misses 0 5 +5
- Partials 0 4 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taxpayer_id_typeandhas_valid_ssnperson variableshas_tinresolve from explicit inputs or the new taxpayer ID primitive during migrationssn_card_typeWhy
Current federal rules use two distinct identification concepts:
TIN) rules for filer/dependent eligibility in several placesThis PR makes that split explicit in
policyengine-us, while preservinghas_itinas a temporary compatibility alias for existing callers.Companion data PR: PolicyEngine/policyengine-us-data#715