Replace IL LIHEAP simplified payment model with full benefit matrix#7963
Open
hua7450 wants to merge 6 commits intoPolicyEngine:mainfrom
Open
Replace IL LIHEAP simplified payment model with full benefit matrix#7963hua7450 wants to merge 6 commits intoPolicyEngine:mainfrom
hua7450 wants to merge 6 commits intoPolicyEngine:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7963 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 4 +3
Lines 17 72 +55
=========================================
+ Hits 17 72 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These are now superseded by the full benefit matrix lookup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…xpenses - Derive CASH fuel type from heat_expense_included_in_rent - Fix income bracket thresholds to 0.51/1.01/1.51 (matching PDF labels) - Cap non-cash benefits at actual heating expenses (electricity + gas + fuel oil) - Use SPMUnit utility variables consistent with MA/DC LIHEAP - Fix parameter descriptions per PolicyEngine standards - Update tests to use SPMUnit expense variables Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Derive fuel type from gas/fuel_oil/bottled_gas/coal/metered_gas expenses - Add heating_cooling_expense, bottled_gas_expense, metered_gas_expense, coal_expense to expense cap - Rewrite tests to verify inference logic (no explicit fuel type override) - Add test cases for bottled gas, coal, metered gas, heating_cooling_expense Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PavelMakarchuk
requested changes
Apr 10, 2026
Collaborator
PavelMakarchuk
left a comment
There was a problem hiding this comment.
AI review found a likely regression.
Summary: The PR introduces a breaking regression for existing IL LIHEAP inputs by no longer honoring generic heating expenses when capping the base benefit.
Finding:
policyengine_us/variables/gov/states/il/dceo/liheap/payment/il_liheap_base_payment.py:37- Existing
heating_expense_personinputs now appear to produce a zero LIHEAP payment. origin/maincomputes IL LIHEAP fromheating_expense_person, but this PR caps non-cash benefits using only utility-specific SPM-unit expenses. A household still providing the previously supported input shape, for exampleheating_expense_person: 1000with nogas_expenseorelectricity_expense, now getsil_liheap_base_payment = 0instead of the prior positive payment becauseheating_expensesbecomes 0 and the inferred fuel type falls back toALL_ELECTRIC.- Unless
heating_expense_personis being explicitly deprecated everywhere, this looks like a silent underpayment regression and needs either backward-compatible support or a migration path plus coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_amount/min.yamlandbase_amount/max.yamlparametersRegulatory Authority
Design Decisions
heat_in_rent → CASH,fuel_oil/coal → PROPANE_FUEL_OIL,gas/bottled_gas/metered_gas → NAT_GAS_OTHER, otherwiseALL_ELECTRIC. User can still override explicitly.min(matrix_amount, sum of 7 heating expenses)—electricity_expense,gas_expense,fuel_oil_expense,heating_cooling_expense,bottled_gas_expense,metered_gas_expense,coal_expense. Consistent with MA and DC LIHEAP. Cash (heat in rent) is a direct payment with no expense cap.Files
New
parameters/gov/states/il/dceo/liheap/payment/matrix/— 4 matrix YAML filesparameters/gov/states/il/dceo/liheap/payment/income_bracket.yaml— bracket parametervariables/gov/states/il/dceo/liheap/il_liheap_fuel_type.py— fuel type enum + inference from expensesvariables/gov/states/il/dceo/liheap/il_liheap_income_bracket.py— derived from FPL %Modified
variables/gov/states/il/dceo/liheap/payment/il_liheap_base_payment.py— matrix lookup + expense capvariables/gov/states/il/dceo/liheap/eligibility/il_liheap_eligible.py— immigration commentparameters/gov/states/il/dceo/liheap/payment/crisis_amount/max.yaml— corrected FY2024Removed
parameters/gov/states/il/dceo/liheap/payment/base_amount/max.yaml— superseded by matrixparameters/gov/states/il/dceo/liheap/payment/base_amount/min.yaml— superseded by matrixTest plan
il_liheap_fuel_typeoverride)🤖 Generated with Claude Code